-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix error toast popping up in Workpace Creator view #9855
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9855 +/- ##
==========================================
- Coverage 54.71% 50.56% -4.15%
==========================================
Files 1261 938 -323
Lines 155988 126645 -29343
Branches 3590 3590
==========================================
- Hits 85342 64035 -21307
+ Misses 70514 62478 -8036
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit 6e08303)
Ticket
Description
Error Toast saying "failed to get listNamespace Bindings" pops up when you log in as a Workspace Creator, and try to edit the workspace. Fixed that by adding user permission checks to API request
Test Plan
Checklist
docs/release-notes/
See Release Note for details.