Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error toast popping up in Workpace Creator view #9855

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Aug 21, 2024

Ticket

Description

Error Toast saying "failed to get listNamespace Bindings" pops up when you log in as a Workspace Creator, and try to edit the workspace. Fixed that by adding user permission checks to API request

Test Plan

  • spin up a minikube cluster, and login with different roles such as Cluster Admin, Workspace Admin, editor, Workspace Creator and perform different workspace and namespace bindings actions and make sure no errors come up.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit b663cc4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66c672eeff2b0e0008ad0bea
😎 Deploy Preview https://deploy-preview-9855--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.56%. Comparing base (707ad07) to head (b663cc4).
Report is 9 commits behind head on main.

Files Patch % Lines
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9855      +/-   ##
==========================================
- Coverage   54.71%   50.56%   -4.15%     
==========================================
  Files        1261      938     -323     
  Lines      155988   126645   -29343     
  Branches     3590     3590              
==========================================
- Hits        85342    64035   -21307     
+ Misses      70514    62478    -8036     
  Partials      132      132              
Flag Coverage Δ
harness ?
web 54.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% <0.00%> (ø)

... and 323 files with indirect coverage changes

@salonig23 salonig23 requested a review from johnkim-det August 22, 2024 16:05
@salonig23 salonig23 marked this pull request as ready for review August 22, 2024 16:06
@salonig23 salonig23 requested a review from a team as a code owner August 22, 2024 16:06
Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salonig23 salonig23 merged commit 6e08303 into main Aug 23, 2024
88 of 101 checks passed
@salonig23 salonig23 deleted the fix-error-toast branch August 23, 2024 17:36
@corban-beaird corban-beaird added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Aug 23, 2024
corban-beaird pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants