-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use task sessions in Core API [MD-509] #9860
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9860 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 1261 1261
Lines 155984 156013 +29
Branches 3589 3588 -1
=======================================
+ Hits 85348 85367 +19
- Misses 70504 70514 +10
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
session = authentication.login_from_task( | ||
master_address=info.master_url, | ||
cert=cert, | ||
).with_retry(util.get_max_retries_config()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this still work for init of core api in detached mode? think we have to fall back to user auth when not in a task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think so? detached mode checks if it's on cluster or not, and if it is, it uses this login_from_task
. if not, it uses the session from the sdk client. in _make_v2_context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, makes sense
Ticket
Description
use task session tokens instead of user session tokens in the
CoreContext
and other internal tasks, since some experiments are long running and will expire within the 7 day user token deadline.Test Plan
make sure that the session token is being used on the core context, and that it's not the user token
Checklist
docs/release-notes/
See Release Note for details.