fix: reset Model Registry page number on pageload [ET-640]

[EmilyBonar]

Ticket

ET-640

Description

Resets the user setting of tableOffset on page load. I investigated more elegant ways to solve this, such as removing tableOffset from the settings config and only storing it in the URL params, but InteractiveTable and useSettings are tightly coupled enough that it would take a not-insignificant refactor to do so.

Test Plan

• Go to Model Registry page
• Use the Pagination component to change the table page number
• Navigate away from Model Registry page
• Navigate back to Model Registry page
• Confirm that the table is on its first page, not the one you navigated to in the second step

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 50.55%. Comparing base (2b1856a) to head (b69dddd).
Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
webui/react/src/components/ModelRegistry.tsx	0.00%	34 Missing ⚠️
...bui/react/src/components/ModelRegistry.settings.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9876      +/-   ##
==========================================
- Coverage   54.70%   50.55%   -4.16%     
==========================================
  Files        1261      938     -323     
  Lines      156013   126685   -29328     
  Branches     3588     3589       +1     
==========================================
- Hits        85348    64041   -21307     
+ Misses      70533    62512    -8021     
  Partials      132      132              

Flag	Coverage Δ
harness	?
web	54.46% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...bui/react/src/components/ModelRegistry.settings.ts	0.00% <0.00%> (ø)
webui/react/src/components/ModelRegistry.tsx	0.00% <0.00%> (ø)

... and 323 files with indirect coverage changes

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	b69dddd
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66d1fe9a5fc425000893e233
😎 Deploy Preview	https://deploy-preview-9876--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ashtonG]

you should be able to:

1. remove the page offset from the setting schema
2. create a new schema that is just the tableOffset (maybe io.exact({ tableOffset: io.number }), which would strip extra properties from the input/output), and use useTypedParams to handle reading and writing to the parameters
3. create a type representing the intersection between your settings schema and the new schema together
4. wrap updateSettings in a function that takes that intersection and passes the resulting settings object to both the original updateSettings and the updateParams from useTypedParams.

without doing major refactoring.

[ashtonG]

for posterity, see previous comment

[ashtonG]

LGTM, just picked a few nits.