Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement custom trigger for webhooks #9879

Merged
merged 21 commits into from
Sep 9, 2024

skip wrong webhook id

f72241e
Select commit
Loading
Failed to load commit list.
Merged

feat: Implement custom trigger for webhooks #9879

skip wrong webhook id
f72241e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 1s

54.61% (-0.07%) compared to 036477b

View this Pull Request on Codecov

54.61% (-0.07%) compared to 036477b

Details

Codecov Report

Attention: Patch coverage is 3.34928% with 202 lines in your changes missing coverage. Please review.

Project coverage is 54.61%. Comparing base (036477b) to head (f72241e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/webhooks/postgres_webhook.go 4.23% 113 Missing ⚠️
webui/react/src/components/WebhookCreateModal.tsx 0.00% 43 Missing ⚠️
master/internal/webhooks/api_webhook.go 0.00% 21 Missing ⚠️
harness/determined/core/_context.py 12.50% 14 Missing ⚠️
webui/react/src/pages/WebhookList.tsx 0.00% 7 Missing ⚠️
master/internal/webhooks/webhook.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9879      +/-   ##
==========================================
- Coverage   54.67%   54.61%   -0.07%     
==========================================
  Files        1263     1263              
  Lines      156862   157047     +185     
  Branches     3597     3598       +1     
==========================================
+ Hits        85768    85769       +1     
- Misses      70963    71147     +184     
  Partials      131      131              
Files with missing lines Coverage Δ
master/internal/webhooks/webhook.go 12.00% <0.00%> (-0.50%) ⬇️
webui/react/src/pages/WebhookList.tsx 0.00% <0.00%> (ø)
harness/determined/core/_context.py 53.04% <12.50%> (-4.67%) ⬇️
master/internal/webhooks/api_webhook.go 0.00% <0.00%> (ø)
webui/react/src/components/WebhookCreateModal.tsx 0.00% <0.00%> (ø)
master/internal/webhooks/postgres_webhook.go 48.70% <4.23%> (-11.94%) ⬇️

... and 4 files with indirect coverage changes