Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features: date localization, week starts with & text color for months and days #26

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Eimji
Copy link

@Eimji Eimji commented Oct 30, 2023

Hello

Thanks for your great package.
I would like to submit the following changes:

  • date localization (months & week days)
  • new option to specify wich day the week should start (weekStartsWith = 1 for Monday, ..., weekStartsWith = 7 for Sunday)
  • new option to set a separate color for month and day labels in the HeatMap widget
  • update the example app

Please merge my PR as it will fix the following issues
#25
#18
#10
#17
#8

Thanks

@Sun3
Copy link

Sun3 commented Feb 6, 2024

Can you give an estimated date when these features will be released? I am really interested in week day starts on Sunday or Monday feature.

Thanks.

Copy link

@rmsmani rmsmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the screenshots of the fix

@Eimji
Copy link
Author

Eimji commented Feb 17, 2024

@rmsmani you want me to add screenshots for which features ? Not sure to understand.

Thanks

@rmsmani
Copy link

rmsmani commented Feb 17, 2024

For the new features which were developed by you....

@Eimji
Copy link
Author

Eimji commented Feb 18, 2024

For the new features which were developed by you....

Clone my fork, and you can try the example application to see the new features. No need for screenshots.

Copy link

@rmsmani rmsmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good to have the screen shot in the PR for future reference.

@fodil-a
Copy link

fodil-a commented Jun 14, 2024

this should've been fixed, what can be done to merge it ?

@nkolatsis
Copy link

So is this getting released or not? @rmsmani

@rmsmani
Copy link

rmsmani commented Oct 2, 2024

Repo owner should accept the pr

@nkolatsis
Copy link

Repo owner should accept the pr

@Eimji now you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants