Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine - Install libssl1.1 only if available #793

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

eljog
Copy link
Member

@eljog eljog commented Jan 8, 2024

Alpine repo for 3.19 does not include the outdated libssl1.1.
This is a blocker for upgrading alpine image to 3.19 devcontainers/images#786, as the image uses on common-utils feature.

Error details:
https://github.com/devcontainers/images/actions/runs/7282516027/job/20100948870?pr=897#step:3:906

@eljog eljog requested a review from a team as a code owner January 8, 2024 19:32
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wonder if we should also mirror installing libssl 3 (like we do on the debian side) in case alpine drops libssl 3

@eljog
Copy link
Member Author

eljog commented Jan 8, 2024

I wonder if we should also mirror installing libssl 3

Since we don't install that explicitly today, I think we can leave it as it is, unless a need arises in the future.

@eljog eljog merged commit 5258a80 into main Jan 8, 2024
11 checks passed
@eljog eljog deleted the eljog/alpine-conditional-libssl1.1 branch January 8, 2024 21:16
eljog added a commit that referenced this pull request Jan 8, 2024
eljog added a commit that referenced this pull request Jan 8, 2024
samruddhikhandale added a commit to devcontainers/templates that referenced this pull request Jan 18, 2024
samruddhikhandale added a commit to devcontainers/templates that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants