Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python]-setuptools-GHSA-r9hx-vwmv-q579-remove setuptools-65.5.0-py3-none-any.whl #866

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Feb 16, 2024

Feature name:

  • Python

Description:

This PR patches the following vulnerability:

Changelog:

  • Updated install.sh file

    • Replaced setuptools-65.5.0-py3-none-any.whl with setuptools-69.1.0-py3-none-any.whl
      • Downloaded setuptools source distribution;
      • Extracted and built from unzipped source distribution contents, the required file.
      • Updated __init__.py file inside ensurepip folder to have the corresponding correct version of setuptools.
  • Updated tests to verify that the vulnerable file setuptools-65.5.0-py3-none-any.whl no longer exists, which fixes GHSA-r9hx-vwmv-q579);

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner February 16, 2024 08:35
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool, thank you so much for taking a stab at fixing it

src/python/install.sh Outdated Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
src/python/install.sh Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
test/python/install_python311_setuptools_vulnerability.sh Outdated Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
test/python/install_python311_setuptools_vulnerability.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me! Left one minor comment.

test/python/scenarios.json Show resolved Hide resolved
src/python/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants