Create build workflow #15
Conversation
|
youre not using the docker container, use the docker container |
|
Alright, I've switched to the docker container, but it's still 403ing when I do dkp-pacman -Syu |
|
because you don't need to do the pacman -Syu, thats not up to the workflow to manage :) |
|
It builds until it reaches the crypto examples (failes on SHA Engine Example), I do suspect the images would need to be updated too, since all examples build fine on all my other systems and the old workflow. |
|
ye, they'll need updating. i suggest removing the |
|
Done that already. |
|
@dakotath, is there a reason why you changed from |
|
Honestly I forgot I even changed that |
|
by the way, github actions runners all have 4 cores now, so you can use -j4 |
can't this be fixed by editing the commit message when doing a squash merge? |
The comment is for information in a vain attempt to get people to name things properly and stop the random capitalisation. This commit message wouldn't appear on squash and the contributor would remain unaware of the proper naming assuming this gets merged. Personally I don't really see the benefit of a workflow here and I really don't see the benefit of providing artifacts for an examples repository intended to illustrate use of the tools and also serve as a test for installed tools/libs. |
|
|
||
| - name: Build | ||
| run: | | ||
| make -j2 |
There was a problem hiding this comment.
-j2 should be replaced with $(nproc) as I did here switchbrew/libnx@d6e38f2
Runners currently have up to 4 cores but I've still seen 2 core runners recently and of course they may up the cores in the future.
| run: | | ||
| make -j2 | ||
|
|
||
| - name: Upload Build Artifacts |
There was a problem hiding this comment.
uploading artifacts from an examples repository just seems like a waste of resources to me.
There was a problem hiding this comment.
It's not necessary your own storage that's getting used during the process, so it doesn't really seem like a big deal to me. And also, there are things in certain build environments that break, and I see useful to testing things in multiple build environments (including actions). For example: sometimes I'll update libogc on my Arch laptop and then everything breaks to the point of the exception handler not even working. (This type of result has never been solidly reproducible so don't ask me how to reproduce it). Besides that, I'll get to the rest of the file when I'm done the day.
Moving the build workflow over here, something is going on with devkitPro package servers, because it's all returning 403 now on this workflows.