Responsive app #356
Open
Responsive app #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves most of my bullet points in #347.
(I left the calculations of the heatmap out.)
I though I'd better share the changes I did regarding this, now that @PAVAN507-STAR is showing an interest as well.
It would be great if you all could do some testing to identify any bugs that I've overlooked, @wurstbrot, @0x41head, @PAVAN507-STAR. I've tried to bulk changed into separate commits, per bullet point.
I have moved the Heatmap up as then main page, even you were not quite convinced @wurstbrot. We can figure out if we want a feature toggle in code, in yaml, or save last page. But I do find the heatmap do give a better overview. And that is what I'd like my users to see first. And for the returning users that are welcome to go straight to the Matrix, to look at the details.
But this is a fairly common pattern: Start with the overview. Then dig into the details.
I'm happy do hear you guys' point of view. :)