feat: add http_request_next method (large asset support) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-shahi
approved these changes
Mar 17, 2021
|
|
||
| #[derive(CandidType, Deserialize)] | ||
| pub struct HttpGetChunkResponse { | ||
| pub chunk: Vec<u8>, |
There was a problem hiding this comment.
Suggested change
| pub chunk: Vec<u8>, | |
| #[serde(with = "serde_bytes")] | |
| pub chunk: Vec<u8>, |
p-shahi
reviewed
Mar 17, 2021
| @@ -29,6 +29,18 @@ pub struct HttpResponse { | |||
| pub body: Vec<u8>, | |||
| } | |||
|
|
|||
| #[derive(CandidType)] | |||
| pub struct HttpGetChunkRequest { | |||
There was a problem hiding this comment.
can this be moved inside the body of http_get_chunk similar to https://github.com/dfinity/agent-rs/blob/next/ic-utils/src/interfaces/management_canister.rs#L453
hansl
suggested changes
Mar 17, 2021
ericswanson-dfinity
changed the title
hansl
suggested changes
Mar 18, 2021
| @@ -192,6 +193,25 @@ impl Argument { | |||
| } | |||
| } | |||
|
|
|||
| /// Add an IDLValue Argument. If the current value of Argument is Raw, will set the | |||
| /// result to an error. If the current value is an error, will do nothing. | |||
| pub fn push_value_arg(&mut self, arg: IDLValue) { | |||
There was a problem hiding this comment.
IDLValue implements CandidType, so you should be able to use push_idl_arg with an IDLValue. Was there any issue with using that other function?
There was a problem hiding this comment.
Yes, IDLValue::ty() calls unreachable() : https://github.com/dfinity/candid/blob/master/rust/candid/src/parser/value.rs#L326
called from here: https://github.com/dfinity/candid/blob/master/rust/candid/src/ser.rs#L28
| @@ -258,6 +278,16 @@ impl<'agent, 'canister: 'agent, Interface> SyncCallBuilder<'agent, 'canister, In | |||
| self | |||
| } | |||
|
|
|||
| /// Add an argument to the candid argument list. This requires Candid arguments, if | |||
| /// there is a raw argument set (using [with_arg_raw]), this will fail. | |||
| pub fn with_value_arg( | |||
hansl
approved these changes
Mar 18, 2021
|
Entered #132 to make |
hansl
approved these changes
Mar 18, 2021
ericswanson-dfinity
deleted the
ericswanson/126-http-server-chunked-assets
branch
mergify bot
pushed a commit
to dfinity/sdk
that referenced
this pull request
Mar 22, 2021
1. The `http_request` response now includes an optional `next_token` field if there are more chunks after the first 2. The `dfx` built-in webserver calls `http_request_next` to get subsequent chunks Requires dfinity/agent-rs#129 Implements dfinity/dx-triage#126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/dfinity/dx-triage/issues/126
See also dfinity/sdk#1512