feat: Misc icx fixes #498
Open
feat: Misc icx fixes #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Dec 1, 2023
| .await | ||
| .context("Failed to fetch root key from replica")?; | ||
| async fn fetch_root_key_from_non_ic(agent: &Agent, replica: &Url) -> Result<()> { | ||
| if is_mainnet(replica) { |
There was a problem hiding this comment.
Shouldn't this logic be the opposite? We should never fetch the root key on mainnet, and should always fetch it elsewhere.
Suggested change
| if is_mainnet(replica) { | |
| if !is_mainnet(replica) { |
There was a problem hiding this comment.
We could also consider the approach that icx-proxy takes: adding a --fetch-root-key parameter.
https://github.com/dfinity/ic/blob/master/rs/boundary_node/icx_proxy/src/main.rs#L83
nikolay-komarevskiy
pushed a commit
to nikolay-komarevskiy/agent-rs
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary target of this PR is updating the URLs that the root key is fetched for to include icp-api.io and icp0.io, while making the default port 4943, but I also took the opportunity to fix some documentation and panics, add a
--icflag as shorthand for mainnet, and make the flags repositionable.