Skip to content

Commit

Permalink
Merge branch 'gdemay/XC-49-fix-label-clash' into 'master'
Browse files Browse the repository at this point in the history
fix(ckerc20): fix label clash in metrics

(XC-49): Fix a bug introduced in [MR-19112](https://gitlab.com/dfinity-lab/public/ic/-/merge_requests/19112), where the `token` label used for the metric `cketh_minter_erc20_balances` collides with the scrapping job for the minter. 

See merge request dfinity-lab/public/ic!19150
  • Loading branch information
gregorydemay committed May 7, 2024
2 parents 1c6e40f + 792faa8 commit 20da742
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rs/ethereum/cketh/minter/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -864,8 +864,8 @@ fn http_request(req: HttpRequest) -> HttpResponse {
"Known amount of ERC-20 on the minter's address",
)?;
for (token, balance) in s.erc20_balances_by_token_symbol().iter() {
erc20_balances =
erc20_balances.value(&[("token", &token.to_string())], balance.as_f64())?;
erc20_balances = erc20_balances
.value(&[("erc20_token", &token.to_string())], balance.as_f64())?;
}
w.encode_gauge(
"cketh_minter_total_effective_tx_fees",
Expand Down

0 comments on commit 20da742

Please sign in to comment.