Merge branch 'fix-sns-script' into 'master'

chore: Fix sns-canister-publish proposal generation script

This fixes the script's self-documentation and validation to be consistent with what's intended. 

See merge request dfinity-lab/public/ic!20143

testnet/tools/nns-tools/prepare-publish-sns-wasm-proposal-text.sh

@@ -6,7 +6,7 @@ source "$NNS_TOOLS_DIR/lib/include.sh"
 
 help() {
     print_green "
-Usage: $0 <SNS_CANISTER_TYPE> <TARGET_VERSION> <LAST_PUBLISHED_VERSION> (<OUTPUT_FILE>)
+Usage: $0 <SNS_CANISTER_TYPE> <TARGET_VERSION> (<OUTPUT_FILE>)
   SNS_CANISTER_TYPE: Canister type to be published (root, governance, ledger, swap, archive, index)
   TARGET_VERSION: Git hash of new version to be published to production
   OUTPUT_FILE: File to write contents to (otherwise stdout is used)
@@ -21,14 +21,14 @@ Usage: $0 <SNS_CANISTER_TYPE> <TARGET_VERSION> <LAST_PUBLISHED_VERSION> (<OUTPUT
     exit 1
 }
 
-if [ $# -lt 3 ]; then
+if [ $# -lt 2 ]; then
     help
 fi
 
 SNS_CANISTER_TYPE=$1
 TARGET_VERSION=$2
 OUTPUT_FILE=${3:-}
-LAST_PUBLISHED_VERSION=${LAST_PUBLISHED_VERSION:-$(sns_mainnet_git_commit_id $SNS_CANISTER_TYPE)}
+LAST_PUBLISHED_VERSION=${LAST_PUBLISHED_VERSION:-$(sns_mainnet_git_commit_id "$SNS_CANISTER_TYPE")}
 
 IC_ROOT=$(repo_root)