chore(IDX): remove RUN_CI var (#274)

We can remove this as we are now always running CI and this cleans up things. --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation> Co-authored-by: IDX GitHub Automation <[email protected]>
dfinity · Jun 27, 2024 · 40d476b · 40d476b
1 parent 6a6470d
commit 40d476b
Show file tree

Hide file tree

Showing 12 changed files with 9 additions and 40 deletions.
diff --git a/.github/workflows-source/ci-main.yml b/.github/workflows-source/ci-main.yml
@@ -47,7 +47,6 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
   before-script: &before-script
     name: Before script
     id: before-script
@@ -124,7 +123,7 @@ jobs:
     name: Bazel Test Darwin x86-64
     timeout-minutes: 120
     # TODO: enable once we have more macos runners
-    if: ${{ vars.RUN_CI == 'true' && github.event_name == 'schedule' }}
+    if: ${{ github.event_name == 'schedule' }}
     runs-on:
       labels: macOS
     steps:
@@ -198,7 +197,6 @@ jobs:
     name: Python CI Tests
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - <<: *checkout
       - <<: *python-setup
@@ -217,7 +215,7 @@ jobs:
   build-ic:
     name: Build IC
     <<: *dind-large-setup
-    if: ${{ vars.RUN_CI == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ github.event_name != 'merge_group' }}
     steps:
       - <<: *checkout
       - <<: *before-script
@@ -248,7 +246,6 @@ jobs:
     name: Build Determinism
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     needs: [build-ic, bazel-test-all]
     strategy:
       matrix:

diff --git a/.github/workflows-source/ci-pr-only.yml b/.github/workflows-source/ci-pr-only.yml
@@ -27,14 +27,12 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
   dind-large-setup: &dind-large-setup
     runs-on:
       group: dind-large
     container:
       <<: *image
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
   before-script: &before-script
     name: Before script
     id: before-script

diff --git a/.github/workflows-source/release-testing.yml b/.github/workflows-source/release-testing.yml
@@ -34,7 +34,6 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 180 # 3 hours
-    if: ${{ vars.RUN_CI == 'true' }}
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4

diff --git a/.github/workflows-source/schedule-daily.yml b/.github/workflows-source/schedule-daily.yml
@@ -31,7 +31,6 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 120
-    if: ${{ vars.RUN_CI == 'true' }}
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4
@@ -70,7 +69,7 @@ jobs:
     <<: *dind-large-setup
     timeout-minutes: 720 # 12 hours
     # TODO: disable in GitLab before enabling here
-    if: ${{ vars.RUN_CI == 'true' && false }}
+    if: ${{ && false }}
     strategy:
       matrix:
         targets: ["//rs/crypto/...", "//rs/state_manager/..."]
@@ -95,7 +94,7 @@ jobs:
     <<: *dind-large-setup
     timeout-minutes: 120
     # TODO: enable when zh1 is active again
-    if: ${{ vars.RUN_CI == 'true' && false }}
+    if: ${{ false }}
     steps:
       - <<: *checkout
       - <<: *before-script
@@ -123,7 +122,6 @@ jobs:
     name: Bazel Test NNS Nightly
     <<: *dind-large-setup
     timeout-minutes: 20
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - <<: *checkout
       - <<: *before-script
@@ -142,7 +140,6 @@ jobs:
     name: Bazel System Test Benchmarks
     <<: *dind-large-setup
     timeout-minutes: 480
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - <<: *checkout
       - <<: *before-script

diff --git a/.github/workflows-source/schedule-hourly.yml b/.github/workflows-source/schedule-hourly.yml
@@ -32,7 +32,6 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 120
-    if: ${{ vars.RUN_CI == 'true' }}
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4

diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml
@@ -41,7 +41,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -89,7 +88,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     name: Bazel Build All Config Check
     steps:
       - name: Checkout
@@ -113,7 +111,7 @@ jobs:
     name: Bazel Test Darwin x86-64
     timeout-minutes: 120
     # TODO: enable once we have more macos runners
-    if: ${{ vars.RUN_CI == 'true' && github.event_name == 'schedule' }}
+    if: ${{ github.event_name == 'schedule' }}
     runs-on:
       labels: macOS
     steps:
@@ -167,7 +165,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -191,7 +188,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -212,7 +208,6 @@ jobs:
     name: Python CI Tests
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -240,7 +235,7 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ github.event_name != 'merge_group' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -276,7 +271,6 @@ jobs:
     name: Build Determinism
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     needs: [build-ic, bazel-test-all]
     strategy:
       matrix:
@@ -333,7 +327,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -369,7 +362,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml
@@ -23,7 +23,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 90
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -55,7 +54,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -88,7 +86,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 30
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/container-base-images.yml b/.github/workflows/container-base-images.yml
@@ -28,7 +28,6 @@ jobs:
     name: Build Base Container Image
     runs-on: ubuntu-latest
     timeout-minutes: 45
-    if: ${{ vars.RUN_CI == 'true' }}
     strategy:
       matrix:
         include:
@@ -107,7 +106,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     needs: [build-base-image]
-    if: ${{ vars.RUN_CI == 'true' && github.ref_name == 'master' }}
+    if: ${{ github.ref_name == 'master' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml
@@ -30,7 +30,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 180 # 3 hours
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -55,7 +54,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 180 # 3 hours
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -78,7 +76,6 @@ jobs:
       group: dind-large
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
-    if: ${{ vars.RUN_CI == 'true' }}
     timeout-minutes: 90
     steps:
       - name: Checkout

diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml
@@ -49,7 +49,7 @@ jobs:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 720 # 12 hours
     # TODO: disable in GitLab before enabling here
-    if: ${{ vars.RUN_CI == 'true' && false }}
+    if: ${{ && false }}
     strategy:
       matrix:
         targets: ["//rs/crypto/...", "//rs/state_manager/..."]
@@ -80,7 +80,7 @@ jobs:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 120
     # TODO: enable when zh1 is active again
-    if: ${{ vars.RUN_CI == 'true' && false }}
+    if: ${{ false }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -114,7 +114,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 20
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -139,7 +138,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 480
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/schedule-hourly.yml b/.github/workflows/schedule-hourly.yml
@@ -28,7 +28,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 120
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -49,7 +48,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 120
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -73,7 +71,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 120
-    if: ${{ vars.RUN_CI == 'true' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/schedule-weekly.yml b/.github/workflows/schedule-weekly.yml
@@ -16,7 +16,6 @@ jobs:
     container:
       image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
     timeout-minutes: 60 # 1 hour
-    if: ${{ vars.RUN_CI == 'true' }} # needed to avoid running on public dfinity org until published
     steps:
       - name: Checkout
         uses: actions/checkout@v4