Skip to content

Commit

Permalink
chore(IDX): disable closure tests (#2103)
Browse files Browse the repository at this point in the history
The `principal_to_bytes` test uses the deprecated
[closure](https://github.com/google/closure-library) framework. The
`rules_closure` are causing flakiness in our Bazel build.

Because the `principal_to_bytes` code is rarely (if ever) changed we
temporarily disable the tests, until a better solution is found.
  • Loading branch information
nmattia authored Oct 17, 2024
1 parent b7bf79f commit 7503772
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions rs/ethereum/cketh/minter/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ rust_binary(
closure_js_library(
name = "principal_to_bytes",
srcs = ["templates/principal_to_bytes.js"],
# We don't automatically build this because the build is unreliable.
tags = ["manual"],
# the test doesn't need to run on macOS; just linux is enough
target_compatible_with = [
"@platforms//os:linux",
Expand All @@ -246,6 +248,8 @@ closure_js_library(
closure_js_test(
name = "principal_to_bytes_test",
srcs = ["tests/principal_to_bytes_test.js"],
# We don't automatically build this because the build is unreliable.
tags = ["manual"],
# the test doesn't need to run on macOS; just linux is enough
target_compatible_with = [
"@platforms//os:linux",
Expand Down

0 comments on commit 7503772

Please sign in to comment.