Skip to content

Commit

Permalink
test(ICP_Ledger): FI-1506: Remove flaky flag from ICP ledger and inde…
Browse files Browse the repository at this point in the history
…x tests (#3410)

After limiting parallelization and dedicating more resources to running
the tests, they are no longer flaky (no flakiness observed in the past
week). This PR therefore removes the flaky flag, so that failures would
show up and wouldn't be masked by automatic flakiness-retries.
  • Loading branch information
mbjorkqvist authored Jan 13, 2025
1 parent 250955b commit 92ae5bc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion rs/ledger_suite/icp/index/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ rust_ic_test(
"LEDGER_CANISTER_NOTIFY_METHOD_WASM_PATH": "$(rootpath //rs/ledger_suite/icp/ledger:ledger-canister-wasm-notify-method)",
"LEDGER_CANISTER_WASM_PATH": "$(rootpath //rs/ledger_suite/icp/ledger:ledger-canister-wasm)",
},
flaky = True,
tags = ["cpu:4"],
deps = [":ic-icp-index"] + DEPENDENCIES + DEV_DEPENDENCIES,
)
1 change: 0 additions & 1 deletion rs/ledger_suite/icp/ledger/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ rust_ic_test(
"LEDGER_CANISTER_NEXT_VERSION_WASM_PATH": "$(rootpath :ledger-canister-wasm-next-version)",
"LEDGER_CANISTER_LOW_LIMITS_WASM_PATH": "$(rootpath :ledger-canister-wasm-low-limits)",
},
flaky = True,
tags = ["cpu:4"],
deps = [
# Keep sorted.
Expand Down

0 comments on commit 92ae5bc

Please sign in to comment.