Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ICP_ledger): FI-1388: Add golden state tests to nightly #1015

Merged

Conversation

mbjorkqvist
Copy link
Member

Add the golden state upgrade and downgrade tests for the ICP and ICRC ledgers to the nightly pipeline.

@mbjorkqvist mbjorkqvist changed the title test(ICP_ledger,ICRC_ledger): FI-1388: Add golden state tests to nightly test(ICP_ledger): FI-1388: Add golden state tests to nightly Aug 20, 2024
@github-actions github-actions bot added the test label Aug 20, 2024
@mbjorkqvist
Copy link
Member Author

Created based on this earlier PR. This covers the following tests:

The runtime of should_upgrade_icrc_sns_canisters_with_golden_state is around 55 minutes, mainly due to the call to verify_ledger_state, which for all the ledgers (and archives), retrieves all the blocks, computes the expected balances and allowances, and compares them to those retrieved from the canisters set up using the golden state. With increasing number of transactions in each ledger, and increasing number of SNSs, this number is only expected to grow. The plan is also to add the check to the other tests. Bas mentioned that runtimes of over 60min are problematic, so one option could be to only run that particular check on a subset of the ledgers, e.g., ICP, ckBTC, and ckETH.

@mbjorkqvist mbjorkqvist marked this pull request as ready for review August 21, 2024 08:05
@mbjorkqvist mbjorkqvist requested review from a team as code owners August 21, 2024 08:05
@mbjorkqvist mbjorkqvist added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit 2ffb16a Aug 21, 2024
27 checks passed
@mbjorkqvist mbjorkqvist deleted the mathias-FI-1388-add-ledger-golden-state-tests-to-nightly branch August 21, 2024 14:20
aterga pushed a commit that referenced this pull request Aug 21, 2024
Add the golden state upgrade and downgrade tests for the ICP and ICRC
ledgers to the nightly pipeline.

---------

Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants