Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PocketIC): PocketIC library build on Windows #2094

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Oct 17, 2024

This PR adds a GitHub CI flow for PocketIC library build on Windows.

@github-actions github-actions bot added the chore label Oct 17, 2024
@mraszyk mraszyk marked this pull request as ready for review October 17, 2024 09:47
@mraszyk mraszyk requested review from a team as code owners October 17, 2024 09:47
@cgundy
Copy link
Member

cgundy commented Oct 17, 2024

Another question is whether this needs to be part of the release workflow. If so, you would need to add it like this:
https://github.com/dfinity/ic/blob/master/.github/workflows/release-testing.yml#L23-L26

Though we'd first want to make sure they're very stable so it doesn't block the release pipeline.

@mraszyk
Copy link
Contributor Author

mraszyk commented Oct 17, 2024

Another question is whether this needs to be part of the release workflow.

I wouldn't put that on the release pipeline (at least for now).

@cgundy
Copy link
Member

cgundy commented Oct 17, 2024

Ah actually one more thing - would you mind adding .github/workflows/pocket-ic-build-windows.yml to CODEOWNERS, so you can make changes to it in the future?

@mraszyk
Copy link
Contributor Author

mraszyk commented Oct 17, 2024

would you mind adding .github/workflows/pocket-ic-build-windows.yml to CODEOWNERS, so you can make changes to it in the future?

I'm not sure it's needed as I don't expect further changes and I'd appreciate your review anyway if changes are needed after all.

@mraszyk mraszyk added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit dc88028 Oct 17, 2024
27 checks passed
@mraszyk mraszyk deleted the mraszyk/pic-build-windows branch October 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants