chore(IDX): Add hotfix and release logic #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bas van Dijk <[email protected]> Co-authored-by: Marko Kosmerl <[email protected]>
Adding `system-tests-benchmarks-nightly`. DRY related changes. --------- Co-authored-by: Carly Gundy <[email protected]> Co-authored-by: Bas van Dijk <[email protected]> Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
Once we switch everyone to GitHub we'll revert this change but before that it's beneficial to have it. --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
We previously used `--verbose failures` for debugging but it is not required anymore. Also remove defaults that are already set by the bazel-test-all action: https://github.com/dfinity/ic/blob/master/.github/actions/bazel-test-all/action.yaml#L10-L15. --------- Co-authored-by: Bas van Dijk <[email protected]> Co-authored-by: Marko Kosmerl <[email protected]> Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
marko-k0
reviewed
Jun 24, 2024
marko-k0
reviewed
Jun 24, 2024
marko-k0
reviewed
Jun 25, 2024
marko-k0
reviewed
Jun 25, 2024
marko-k0
approved these changes
Jun 25, 2024
gitlab-dfinity
pushed a commit
that referenced
this pull request
Jun 25, 2024
chore(github-sync): PR#261 / chore(IDX): Add hotfix and release logic [GitHub PR 261](#261) (branch: add-hotfix-and-release-logic) See merge request dfinity-lab/public/ic!20018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main CI jobs need to also run on hotfix and rc branches.
Additionally, we need to run a separate CI job that runs different tests for hotfixes.