Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ICP-ledger): FI-1438: Implement V3 for ICP ledger - migrate allowances to stable structures #2818

Merged
merged 209 commits into from
Dec 11, 2024
Merged

feat(ICP-ledger): FI-1438: Implement V3 for ICP ledger - migrate allowances to stable structures #2818

merged 209 commits into from
Dec 11, 2024

Conversation

maciejdfinity
Copy link
Contributor

No description provided.

maciejdfinity and others added 30 commits September 10, 2024 14:08
@maciejdfinity
v2 version for the icrc ledger
8db3763
@maciejdfinity
update mainnet canisters to v1
619a887
@maciejdfinity
Merge branch 'master' into maciej-icrc-v2
0913c4b
@maciejdfinity
update mainnet canister hash
7f1a685
@maciejdfinity
remove extra clone
702e5d8
@maciejdfinity
approvals in stable memory
d89d15d
Automatically updated Cargo*.lock
ce95fcc
@maciejdfinity
skip arrived_at serialization
df25efd
@maciejdfinity
comment
b262c9a
@maciejdfinity
migrate approvals
2ba7c8f
Automatically updated Cargo*.lock
af7376e
@maciejdfinity
disable ledger while migration and wait for ledger to be ready
0fc1d35
@maciejdfinity
remove approval trimming test
823472c
@maciejdfinity
clippy
871d1e1
@maciejdfinity
build fix
ab60f40
@maciejdfinity
fix candid
f108662
@maciejdfinity
fix tests
e454fbc
@maciejdfinity
fix tests
378c316
@maciejdfinity
clippy
2b64a03
@maciejdfinity
fix tests
9f545df
@maciejdfinity
clippy
82ff283
@maciejdfinity
test account maxserialization len
3171aa0
@maciejdfinity
test account serialization
ed7731d
@maciejdfinity
test allowance serialization
5585594
@maciejdfinity
account for pre_upgrade instructions
eb830db
@maciejdfinity
additional ready checks
247d2e3
@maciejdfinity
remove is_migrating
dbc7f32
@maciejdfinity
migration steps metric
9559981
@maciejdfinity
clippy
35924ed
@maciejdfinity
update limits, do not write in pre_upgrade if not ready
5b7c9a3
@maciejdfinity maciejdfinity marked this pull request as ready for review November 29, 2024 11:43
@maciejdfinity maciejdfinity requested review from a team as code owners November 29, 2024 11:43
mbjorkqvist
mbjorkqvist reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maciejdfinity , I made a first pass and the changes look good! I'll have another more detailed look to see if there's something missing that should be added.

rs/ledger_suite/icp/ledger/Cargo.toml Outdated Show resolved Hide resolved
rs/ledger_suite/icp/ledger/src/lib.rs Show resolved Hide resolved
rs/ledger_suite/tests/sm-tests/src/lib.rs Show resolved Hide resolved
@maciejdfinity maciejdfinity requested a review from mraszyk December 4, 2024 09:02
@maciejdfinity maciejdfinity added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit b006ae9 Dec 11, 2024
25 checks passed
@maciejdfinity maciejdfinity deleted the maciej-icp-v3 branch December 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbjorkqvist mbjorkqvist mbjorkqvist approved these changes

@mraszyk mraszyk mraszyk approved these changes

@aterga aterga aterga approved these changes

Assignees
No one assigned
Labels
feat @finint @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciejdfinity @aterga @mraszyk @mbjorkqvist