chore: Improve Upgrade with Alternative URLs test #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-k0
approved these changes
Jul 1, 2024
kpop-dfinity
approved these changes
Jul 1, 2024
gitlab-dfinity
pushed a commit
that referenced
this pull request
Jul 1, 2024
chore(github-sync): PR#294 / chore: Improve Upgrade with Alternative URLs test [GitHub PR 294](#294) (branch: eichhorl/fix-upgrade-with-url) See merge request dfinity-lab/public/ic!20152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would wait until the node becomes unavailable, as a sign that it was upgrading. This is imprecise and sometimes flaky, see here. The logs reveal that the replica did in fact upgrade successfully, but I suspect the "unhealthy" status didn't persist long enough to be picked up by the test driver.
With this PR we instead wait until the node is running the expected replica version after the upgrade.