fix(consensus): Fix off-by-one error in notary bound #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmllr
approved these changes
Jul 1, 2024
gitlab-dfinity
pushed a commit
that referenced
this pull request
Jul 1, 2024
chore(github-sync): PR#296 / fix(consensus): Fix off-by-one error in notary bound [GitHub PR 296](#296) (branch: alic/CON-fix-ob1) See merge request dfinity-lab/public/ic!20160
nmattia
pushed a commit
that referenced
this pull request
Jul 1, 2024
An off-by-one error in the notary bound leads the notary to stall one height too early. `ACCEPTABLE_NOTARIZATION_CUP_GAP` is inclusive, so this MR changes the notary to correctly notarize heights that are `ACCEPTABLE_NOTARIZATION_CUP_GAP` above the next CUP height. This is now also consistent with the validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An off-by-one error in the notary bound leads the notary to stall one height too early.
ACCEPTABLE_NOTARIZATION_CUP_GAPis inclusive, so this MR changes the notary to correctly notarize heights that areACCEPTABLE_NOTARIZATION_CUP_GAPabove the next CUP height. This is now also consistent with the validator.