test(IDX): increase timeout to 15m for the ic_icp_index_test #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `//rs/ledger_suite/icp/index:ic_icp_index_test` is a bit flaky (~2%) because it occasionally times out after 5 minutes. So we increase the timeout to `long` which is 15 minutes. If it turns out the P90 duration of this test will go over 5 minutes we should look into optimising it or tagging it as a `long_test` to no longer run this on PRs but only on pushes to `master`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
//rs/ledger_suite/icp/index:ic_icp_index_testis a bit flaky (~2%) because it occasionally times out after 5 minutes. So we increase the timeout tolongwhich is 15 minutes.If it turns out the P90 duration of this test will go over 5 minutes we should look into optimising it or tagging it as a
long_testto no longer run this on PRs but only on pushes tomaster.