feat(node): Add node_reward_type field to AddNodePayload and node config

[sasa-tomic]

• Introduce the node_reward_type, to the node configuration and AddNodePayload structures.
• Update related comments and scripts.

[yvonneanne]

Is this field mandatory?

[sasa-tomic]

Is this field mandatory?

@yvonneanne is this description clear enough to answer the question?
https://github.com/dfinity/ic/pull/3116/files#diff-a09d75efc9b8353b91fad185644d25869fa64baab1b2e546f66e9c0dc0606252R16-R35

[yvonneanne]

Is this field mandatory?

@yvonneanne is this description clear enough to answer the question? https://github.com/dfinity/ic/pull/3116/files#diff-a09d75efc9b8353b91fad185644d25869fa64baab1b2e546f66e9c0dc0606252R16-R35

Thanks, that's definitely helpful information but it doesn't entirely answer my question :)
E.g., does this field need to be set for testnet deployments?

The main reason for my question is Utopia. In many Utopia deployments there will be no rewards for nodes and it is not clear from this PR if there will be direct implications for the Utopia team and some provisioning scripts need to be adjusted. Since I don't remember the details of how we set things up, I'll ask Utopia engineers to have a look at the PR and if necessary start a discussion with you.

[sasa-tomic]

The main reason for my question is Utopia.

Oh now I understand, thanks for the clarification @yvonneanne . If the reward table is not set in the registry the node_reward_type will not be checked in the registry, so node registration should succeed without the node_reward_type field set. This should cover both testnet and UTOPIA deployments. I've updated the comment in registration.rs to clarify that.
Is this good enough?

[yvonneanne]

The main reason for my question is Utopia.

Oh now I understand, thanks for the clarification @yvonneanne . If the reward table is not set in the registry the node_reward_type will not be checked in the registry, so node registration should succeed without the node_reward_type field set. This should cover both testnet and UTOPIA deployments. I've updated the comment in registration.rs to clarify that. Is this good enough?

perfect, thanks for adding these explanations!