Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "revert: "feat: [EXC-1753] Add mint_cycles128 API"" #3154

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

michael-weigelt
Copy link
Contributor

@michael-weigelt michael-weigelt commented Dec 12, 2024

#2589 caused a problem in a backup test in the hourly pipeline, so it was reverted in #3125.

#3147 addressed the underlying problem in the backup test and was merged. #3151 is 2589+3147 and shows that the mitigation works, but instead of merging that, it's nicer to revert the revert:

This PR reverts #3125

@michael-weigelt michael-weigelt requested a review from a team as a code owner December 12, 2024 15:30
@michael-weigelt michael-weigelt changed the title Revert "revert: "feat: [EXC-1753] Add mint_cycles128 API"" chore: Revert "revert: "feat: [EXC-1753] Add mint_cycles128 API"" Dec 12, 2024
@github-actions github-actions bot added the chore label Dec 12, 2024
@michael-weigelt michael-weigelt added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Dec 12, 2024
@michael-weigelt michael-weigelt added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit a3d5146 Dec 13, 2024
27 checks passed
@michael-weigelt michael-weigelt deleted the revert-3125-revert-2589-mwe/cycles128 branch December 13, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants