feat(cycles-minting-canister): When memo does not match, fall back to icrc1_memo. #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
reviewed
Jan 6, 2025
aterga
reviewed
Jan 7, 2025
aterga
reviewed
Jan 7, 2025
aterga
reviewed
Jan 7, 2025
aterga
reviewed
Jan 7, 2025
aterga
reviewed
Jan 7, 2025
aterga
approved these changes
Jan 7, 2025
daniel-wong-dfinity-org
deleted the
make-cycles-minting-canister-use-icrc1_memo-daniel-wong
branch
daniel-wong-dfinity-org
added a commit
that referenced
this pull request
Jan 7, 2025
… icrc1_memo. (#3336) # References This implements the first of two features mentioned in [this forum thread][thread]. [thread]: https://forum.dfinity.org/t/extend-cycles-minting-canister-functionality/37749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This implements the first of two features mentioned in this forum thread.
The other feature that was promised in that thread (automatically refund) is implemented in a future PR.