feat(nns): Avoid recomputing wasm/arg hashes during read operations #3490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Calculating hashes for wasm/arg actually takes quite a bit of instructions (80/byte), which makes it the dominant part of the list_proposals instructions. Such hashes can be calculated during write operations easily, since the data should be immutable.
What
wasm_module_hash
andarg_hash
intoInstallCode
internal typeInstallcode
proposals