chore(node): normalize config.sh to return empty string #3502
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
changed the title
Bownairo
reviewed
Jan 17, 2025
Comment on lines
+9
to
+10
| # If key is not found or value is "null", returns empty string. | ||
| # Otherwise, returns value. |
There was a problem hiding this comment.
We talked offline about opening a thread here to discuss. I don't think this is super critical, but still something to think about.
Combining these two cases removes our ability to differentiate between "unset" and "empty" fields in any scripts that use this shim.
We're not using it now, but one example I could think of was for defaults.
Say we have a list of DNS servers to use as default if none are provided via config. We would have no way to set a truly empty list of servers if the "unset" case is also represented by the empty string.
We won't have this issue in Rust - None and Some("") are still two distinct cases - but this means scripts and binaries will see the same config differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize config.sh get_config_value: