Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): 修复issue反馈的问题 #1972

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

DymoneLewis
Copy link
Collaborator

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 6db2495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -439,6 +439,42 @@ export class GraphModel {
throw new Error(`找不到${edge.type}对应的边。`)
}
const edgeModel = new Model(edge, this)
// 根据edgeModel中存储的数据找到当前画布上的起终锚点坐标
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要看下实现有没有问题,从效果上看倒是ok的
录屏2024-11-21 20 28 06

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大佬你好,这样修改后好像会导致折线的调整被重置成默认状态
#2001

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大佬你好,这样修改后好像会导致折线的调整被重置成默认状态 #2001

看到反馈了TvT,正在解

boyongjiong
boyongjiong previously approved these changes Nov 26, 2024
Copy link
Collaborator

@boyongjiong boyongjiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@boyongjiong boyongjiong merged commit d3d45ef into master Nov 26, 2024
1 check passed
@boyongjiong boyongjiong deleted the bugfix/11.21-finishing-issues branch November 26, 2024 07:15
menghany pushed a commit to menghany/LogicFlow that referenced this pull request Nov 28, 2024
* 修复初始化画布时因为节点吸附网格导致的节点与边错位问题 close didi#1954
* line 和 polyline 增加getPath方法 close didi#1929
* 增加节点和边的focus和blur事件上报 close didi#1917

* 节点和边focus和blur事件逻辑优化:处理浏览器默认focus样式问题&增加类型声明
* 修复polyline points内容变化导致的无法解析问题 & 优化初始化边对齐相关逻辑
* line getPath返回数据格式优化

---------

Co-authored-by: liuziqi <[email protected]>
Co-authored-by: 你说呢? <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: 使用BPMNElements 和 BPMNAdapter 导入 bpmn 数据,渲染的 Gateway 错位
3 participants