add some tests functions #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yucongalicechen
commented
Apr 5, 2024
•
yucongalicechen
commented
- added test_get_grid_points.py, test_set_distances_at_angle.py
- Slight mistake in functions.py: when we select the exit point it should be above the grid point, but when the grid point is at the bottom (0, -radius), we should compare the two roots instead of comparing with the grid point
sbillinge
reviewed
Apr 5, 2024
| def test_set_distances_at_angle(): | ||
| actual_gs = Gridded_circle(radius=1, n_points_on_diameter=3, mu=1) | ||
|
|
||
| # tests for acute angles |
There was a problem hiding this comment.
when you do multiple tests it is better to use the @pytest.mark.paramatrize() decorator on the test function and run different examples as a list of tuples. You may be able to google how to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.