-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reusable GitHub CI workflows for test-on-pr and matrix-test CI files #141
Conversation
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
@yucongalicechen thanks unfortunately, there isn't py313 |
Ahh gotcha. I'm trying to fix the error in the CI actually - is this the right place to check/edit? |
Which error are you trying to fix?
This one? |
The CI issue here: https://github.com/diffpy/diffpy.labpdfproc/actions/runs/12215424294/job/34077353886 |
@yucongalicechen I tried to pin Wxpython to 4.2.2. for all of the matrix CI runs: https://github.com/bobleesj/diffpy.labpdfproc/actions/runs/12246303644/job/34161941093?pr=4 it appears only macos-13, py3.11 through 3.13 fails with the following err msg:
My understanding is that if we use |
@yucongalicechen if you want to run the matrix CI, you can add from
to
and then create a PR to your forked |
Thanks Bob! I will try running the CI on my end. For now I will close this PR and add an issue to fix CI in the future? |
yeah we can re-open this PR once gooey supports py313 via conda-forge. |
closed through new issue #142 |
Just sharing an update here. I was not able to reproduce the CI bug using my Intel Mac, with macOs 13.6.3, py3.13
It installed |
closes #135