Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusable GitHub CI workflows for test-on-pr and matrix-test CI files #141

Closed
wants to merge 1 commit into from

Conversation

yucongalicechen
Copy link
Collaborator

closes #135

Copy link

github-actions bot commented Dec 9, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@yucongalicechen yucongalicechen marked this pull request as draft December 9, 2024 22:54
@bobleesj
Copy link
Contributor

bobleesj commented Dec 9, 2024

@yucongalicechen thanks unfortunately, there isn't py313 gooey available on conda-forge (yet). So it is expected to fail.

@yucongalicechen
Copy link
Collaborator Author

@yucongalicechen thanks unfortunately, there isn't py313 gooey available on conda-forge (yet). So it is expected to fail.

Ahh gotcha. I'm trying to fix the error in the CI actually - is this the right place to check/edit?

@bobleesj
Copy link
Contributor

bobleesj commented Dec 9, 2024

@yucongalicechen thanks unfortunately, there isn't py313 gooey available on conda-forge (yet). So it is expected to fail.

Ahh gotcha. I'm trying to fix the error in the CI actually - is this the right place to check/edit?

Which error are you trying to fix?

tests/test_tools.py:7: in <module>
    from diffpy.labpdfproc.labpdfprocapp import get_args
/usr/share/miniconda/envs/test/lib/python3.13/site-packages/diffpy/labpdfproc/labpdfprocapp.py:4: in <module>
    from gooey import Gooey, GooeyParser
E   ModuleNotFoundError: No module named 'gooey'

This one?

@yucongalicechen
Copy link
Collaborator Author

@yucongalicechen thanks unfortunately, there isn't py313 gooey available on conda-forge (yet). So it is expected to fail.

Ahh gotcha. I'm trying to fix the error in the CI actually - is this the right place to check/edit?

Which error are you trying to fix?

tests/test_tools.py:7: in <module>
    from diffpy.labpdfproc.labpdfprocapp import get_args
/usr/share/miniconda/envs/test/lib/python3.13/site-packages/diffpy/labpdfproc/labpdfprocapp.py:4: in <module>
    from gooey import Gooey, GooeyParser
E   ModuleNotFoundError: No module named 'gooey'

This one?

The CI issue here: https://github.com/diffpy/diffpy.labpdfproc/actions/runs/12215424294/job/34077353886

@bobleesj
Copy link
Contributor

bobleesj commented Dec 9, 2024

@yucongalicechen I tried to pin Wxpython to 4.2.2. for all of the matrix CI runs: https://github.com/bobleesj/diffpy.labpdfproc/actions/runs/12246303644/job/34161941093?pr=4

it appears only macos-13, py3.11 through 3.13 fails with the following err msg:

└─ wxpython 4.2.2  is not installable because it requires
   └─ __osx >=11.0 , which is missing on the system.

My understanding is that if we use macos-13, then we are using MacOS13, which means oxs >=13.0. I am afraid this needs to be checked with the devs of wxpython.

@bobleesj
Copy link
Contributor

bobleesj commented Dec 9, 2024

@yucongalicechen thanks unfortunately, there isn't py313 gooey available on conda-forge (yet). So it is expected to fail.

Ahh gotcha. I'm trying to fix the error in the CI actually - is this the right place to check/edit?

@yucongalicechen if you want to run the matrix CI, you can add pull_request under matrix-and-codecov-on-merge-to-main.yml

from

name: CI

on:
  push:
    branches:
      - main
  release:
    types:
      - prereleased
      - published
  workflow_dispatch:

to

name: CI

on:
  push:
    branches:
      - main
  pull_request:
  release:
    types:
      - prereleased
      - published
  workflow_dispatch:

and then create a PR to your forked main branch (no merge) to see all of the matrix CI runs.

@yucongalicechen
Copy link
Collaborator Author

Thanks Bob! I will try running the CI on my end. For now I will close this PR and add an issue to fix CI in the future?

@bobleesj
Copy link
Contributor

yeah we can re-open this PR once gooey supports py313 via conda-forge.

@yucongalicechen
Copy link
Collaborator Author

closed through new issue #142

@bobleesj
Copy link
Contributor

@yucongalicechen

Just sharing an update here. I was not able to reproduce the CI bug using my Intel Mac, with macOs 13.6.3, py3.13

urllib3                   2.2.3              pyhd8ed1ab_1    conda-forge
wxpython                  4.2.2           py313h6799360_3    conda-forge
wxwidgets                 3.2.6                h6e2ffcd_0    conda-forge
xorg-libxau               1.0.11               h00291cd_1    conda-for

It installed wxpython and pytest runs locally.

@yucongalicechen yucongalicechen deleted the 3.13 branch December 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants