-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Math Error Fix #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to make the matplotlib-base work? I would only like to require full matplotlib if we need full matplotlib (i.e., for plotting with a gui)
There's no Unless we change the |
I reached to Tom Caswell for advice on this. We don't want to ship the full matplotlib if we can avoid it to reduce bloat. He may have a recommendation. |
This seems to be failing tests. It is not installing then importing the stylesheet correctly. Please can you take a look. Actually we need a way to delete the package |
@sbillinge Fixed in #132, this PR only changes the Manual (files changed are just the |
Fixing math error in the manual. Change requirements from
matplotlib-base
tomatplotlib
.Using
matplotlib-base
breaks the commandpip install -r https://raw.githubusercontent.com/diffpy/diffpy.pdfmorph/main/requirements/run.txt
in our installation instructions in the README.rst.