Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Math Error Fix #131

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Manual Math Error Fix #131

merged 5 commits into from
Oct 3, 2024

Conversation

Sparks29032
Copy link
Collaborator

Fixing math error in the manual. Change requirements from matplotlib-base to matplotlib.

Using matplotlib-base breaks the command pip install -r https://raw.githubusercontent.com/diffpy/diffpy.pdfmorph/main/requirements/run.txt in our installation instructions in the README.rst.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to make the matplotlib-base work? I would only like to require full matplotlib if we need full matplotlib (i.e., for plotting with a gui)

@Sparks29032
Copy link
Collaborator Author

There's no matplotlib-base for PyPi. On our conda recipe, we only use matplotlib-base in the feedstock.

Unless we change the pip install instructions pip install -r https://raw.githubusercontent.com/diffpy/diffpy.pdfmorph/main/requirements/run.txt, we need matplotlib in our run.txt.. Changing it in run.txt won't affect our conda build though, that will still use the bare bones one.

@sbillinge
Copy link
Contributor

I reached to Tom Caswell for advice on this. We don't want to ship the full matplotlib if we can avoid it to reduce bloat. He may have a recommendation.

@sbillinge
Copy link
Contributor

This seems to be failing tests. It is not installing then importing the stylesheet correctly. Please can you take a look.

Actually we need a way to delete the package bg_mpl_stylesheets, or better, have it resolve to bg-mpl-stylesheets, but either way, we kind of need pdfmorph to install and import correctly.

@Sparks29032
Copy link
Collaborator Author

@sbillinge Fixed in #132, this PR only changes the Manual (files changed are just the texinfo, and pdf).

@diffpy diffpy deleted a comment from github-actions bot Oct 2, 2024
@sbillinge sbillinge merged commit 84966f2 into diffpy:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants