-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move tests and fix pytest #46
Conversation
I will merge this because it is a huge PR, but I am not sure we want all the infrastructure for helping tests pass when different packages are missing. The point of tests is to fail when things are not right, and when dependencies are not available, things are not right, unless we decide that this is desirable behavior. @Tieqiong @bobleesj, can we meet and make a plan for this? I will open an issue to revisit this. S |
@sbillinge Yes, I can meet early next week, Monday morning? @Tieqiong |
I am traveling Monday and won't be available. Please pick a time on my calendar from Tuesday onwards |
@sbillinge @bobleesj How's tomorrow looking? I imagine this will be a quick one. I want to make sure there's enough time to release srreal before the 15th as well. |
I will be flying tmr (Sun). Mon works |
I can't do Monday. @Tieqiong you and I can talk today if you are available. When would be a good time |
@sbillinge Can we meet sometime in the afternoon, like after 3 pm? |
@sbillinge please check, thanks
With
periodictable
installed and alibdiffpy
compiled from the repository againstobjcryst
: