Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move tests and fix pytest #46

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

Tieqiong
Copy link

@Tieqiong Tieqiong commented Jan 11, 2025

@sbillinge please check, thanks

With periodictable installed and a libdiffpy compiled from the repository against objcryst:

image

@sbillinge
Copy link
Contributor

I will merge this because it is a huge PR, but I am not sure we want all the infrastructure for helping tests pass when different packages are missing. The point of tests is to fail when things are not right, and when dependencies are not available, things are not right, unless we decide that this is desirable behavior. @Tieqiong @bobleesj, can we meet and make a plan for this? I will open an issue to revisit this.

S

@sbillinge sbillinge merged commit 5f34e62 into diffpy:cookie Jan 11, 2025
2 checks passed
@bobleesj
Copy link

@sbillinge Yes, I can meet early next week, Monday morning? @Tieqiong

@sbillinge
Copy link
Contributor

I am traveling Monday and won't be available. Please pick a time on my calendar from Tuesday onwards

@Tieqiong
Copy link
Author

Tieqiong commented Jan 11, 2025

@sbillinge @bobleesj How's tomorrow looking? I imagine this will be a quick one. I want to make sure there's enough time to release srreal before the 15th as well.

@bobleesj
Copy link

I will be flying tmr (Sun). Mon works

@sbillinge
Copy link
Contributor

I can't do Monday. @Tieqiong you and I can talk today if you are available. When would be a good time

@Tieqiong
Copy link
Author

@sbillinge Can we meet sometime in the afternoon, like after 3 pm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants