Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace workflows with those from shared templates #351

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

mattdean-digicatapult
Copy link
Contributor

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

https://digicatapult.atlassian.net/browse/SQNC-50

High level description

Changes test and release workflows to use shared workflows

Detailed description

Migrates the test and release workflows to use shared workflows.

Describe alternatives you've considered

None

Operational impact

Release workflow could fail but this won't affect deployments. Would update in a follow up PR

Additional context

N/A

@mattdean-digicatapult mattdean-digicatapult added the v:patch Change requires a semver patch version change label Jan 6, 2025
permissions:
contents: write
secrets:
REGISTRY_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will work. Might need to alter shared workflow to enable publishing to a github npm package

@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review January 6, 2025 17:29
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner January 6, 2025 17:29
@mattdean-digicatapult mattdean-digicatapult merged commit 042d9f9 into main Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:patch Change requires a semver patch version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants