Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support version 22 of node #353

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

mattdean-digicatapult
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult commented Jan 7, 2025

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

https://digicatapult.atlassian.net/browse/SQNC-44

High level description

Sets supported node version to 22 and supported npm to 10

Detailed description

Whilst we were always running on latest lts we previously advertised support for node 22 or higher. We're restricting that now. Technically this is a major bump as it previously advertised support for node above 22 e.g. 23

As a final note the last release failed due to a version overwriting issue in npm that we can't fix. This will publish a new version that will fix all that

Describe alternatives you've considered

N/A

Operational impact

None

Additional context

N/A

@mattdean-digicatapult mattdean-digicatapult added the v:major Change requires a semver major version change label Jan 7, 2025
@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review January 7, 2025 12:00
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner January 7, 2025 12:00
@mattdean-digicatapult mattdean-digicatapult merged commit ed604b5 into main Jan 7, 2025
7 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the chore/version-bump branch January 7, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:major Change requires a semver major version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants