Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also publish to gh npm packages #106

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

mattdean-digicatapult
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult commented Jan 7, 2025

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

Related to https://digicatapult.atlassian.net/browse/SQNC-50

High level description

Publish to gh npm packages as well as npm

Detailed description

Because https://github.com/digicatapult/sqnc-process-management published packages to both npm and github packages I've had to implement digicatapult/shared-workflows#18 so that we can publish to github. As this was a breaking change I'm updating here as well as part of that fix. As an aside this enables us to publish this package to github as well.

Describe alternatives you've considered

Could have just updated the permissions as the minimum. This doesn't really cost anything though and provides another registry option.

Operational impact

See digicatapult/shared-workflows#18 for rollback steps

Additional context

digicatapult/shared-workflows#18

@mattdean-digicatapult mattdean-digicatapult added the v:patch Change requires a semver patch version change label Jan 7, 2025
@mattdean-digicatapult mattdean-digicatapult merged commit b587a05 into main Jan 7, 2025
6 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the feature/gh-npm-package branch January 7, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:patch Change requires a semver patch version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants