Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group enterprise tile #35604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Group enterprise tile #35604

wants to merge 2 commits into from

Conversation

jingcheng16
Copy link
Contributor

@jingcheng16 jingcheng16 commented Jan 9, 2025 •
edited
Loading

Product Description

This PR did two things:

  • Tiles in Platform Overview page are grouped into 3 categories, because we're afraid of showing user 12 tiles at one time can be overwhelming for user ( In the screenshot, it's not 12 tiles yet, some are still under development )
  • The page title for Platform Overview and Security Center is removed. It's a bit redundant when we already mention what this page is about in the left panel and the breadcrumb

Before
image
image

After
image
image

Technical Summary

Ticket: https://dimagi.atlassian.net/browse/SAAS-16426

Feature Flag

Safety Assurance

Safety story

Safe, only change UI

Automated test coverage

QA Plan

No QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@jingcheng16 jingcheng16 marked this pull request as ready for review January 9, 2025 22:08
nospame
nospame reviewed Jan 10, 2025
View reviewed changes
corehq/apps/enterprise/views.py
EnterpriseReport.SMS,
)],
'groups': [
{'name': 'Projects Overview',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to translate the group names here. Otherwise looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nospame nospame nospame left review comments

@biyeun biyeun Awaiting requested review from biyeun

@mjriley mjriley Awaiting requested review from mjriley

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jingcheng16 @nospame