Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #655
prev (wrong): #673
Fix points
run-s
)Uri.fsPath()
instead ofUri.path()
Notes
Tests
Local tests are not working on Windows.
We may need to fix all occurrences of
path.foo()
aspath.posix.foo()
, for example:But since tests on Windows weren't running from the beginning, we might be able to fix this afterwards, since this change affects all test files and also CI for POSIX systems.
(opinions are welcome...)
To have
direnv
work on WindowsAfter you install direnv on Windows and before launching vscode, you need to have your Environmental values set.
refer to: direnv/direnv#1105
(this might be fixed in the future)
Note that you need to set your machine-wide env values, so the commands should be e.g.
(using
setx ... /m,
instead ofset
)on CMD.exe, or
on PowerShell.