Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Windows support #674

Merged
merged 2 commits into from
Dec 14, 2023
Merged

add Windows support #674

merged 2 commits into from
Dec 14, 2023

Conversation

ndac-todoroki
Copy link
Contributor

ref: #655
prev (wrong): #673

Fix points

Notes

Tests

Local tests are not working on Windows.
We may need to fix all occurrences of path.foo() as path.posix.foo(), for example:

- const extensionDevelopmentPath = path.resolve(__dirname, '../..')
+ const extensionDevelopmentPath = path.posix.resolve(__dirname, '../..')

But since tests on Windows weren't running from the beginning, we might be able to fix this afterwards, since this change affects all test files and also CI for POSIX systems.

(opinions are welcome...)

To have direnv work on Windows

After you install direnv on Windows and before launching vscode, you need to have your Environmental values set.
refer to: direnv/direnv#1105
(this might be fixed in the future)

Note that you need to set your machine-wide env values, so the commands should be e.g.

setx DIRENV_CONFIG %APPDATA%\direnv\conf /m

(using setx ... /m, instead of set)

on CMD.exe, or

[Environment]::SetEnvironmentVariable('DIRENV_CONFIG', '%APPDATA%\direnv\conf', 'Machine')

on PowerShell.

@ndac-todoroki ndac-todoroki mentioned this pull request Dec 4, 2023
@mkhl mkhl merged commit bc31864 into direnv:main Dec 14, 2023
4 checks passed
@mkhl
Copy link
Contributor

mkhl commented Dec 14, 2023

Awesome, thank you!

@ndac-todoroki ndac-todoroki deleted the windows2 branch April 6, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants