Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document event data passthrough issues in extended events #2587

Closed
wants to merge 5 commits into from
Closed

Document event data passthrough issues in extended events #2587

wants to merge 5 commits into from

Conversation

freya022
Copy link
Contributor

@freya022 freya022 commented Nov 18, 2023 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This PR document issues with event data passthrough when reconstructing the event from other threads

@freya022
Copy link
Contributor Author

Using the InheritedThreadLocal only allows the event to be passed through seamlessly in quite specific conditions, while the suggested solution should always work, so maybe I should revert that change?

@freya022 freya022 marked this pull request as ready for review November 18, 2023 19:39
@freya022 freya022 closed this Apr 11, 2024
@freya022 freya022 deleted the fix/raw-event-data-thread branch April 11, 2024 09:36
@freya022 freya022 restored the fix/raw-event-data-thread branch April 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freya022 @MinnDevelopment