This repository has been archived by the owner on Dec 24, 2021. It is now read-only.
Add unhandledErrorResponse option, to ignore unhandled errors #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mandoClient options: unhandledErrorResponse Ensure backwards compatibility, defaults to true. If unhandledErorrRepsponse is set to false, a message will return null (no response) if an unhandled error occurs, and allows the commandError emit event to handle the unhandled error.
|
Maybe |
|
I don't think this is the right way to go about doing this - the translations branch will take care of the customisation of this message. |
|
Is it going to be easy to change one message from the current locale set? This seems like a much more difficult way to go, for a user who just wants a little customization. |
|
It should be pretty simple, all you would have to do is extend Commando's locale set and change one entry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in regards to #145. Adds additional parameter to CommandoClient options: unhandledErrorResponse
To ensure backwards compatibility, this defaults to true. If unhandledErrorResponse is set to false, a message will return null (no response) if an unhandled error occurs, and allows the commandError emit event to handle the unhandled error.