Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetchVersions): Sort package versions #10695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 10, 2025

Sorting versions is fine until the minor versions reach two digits:

401832442-dce02418-4bb7-46d8-8115-5ff4f68f2da4

Updated the query to return a correctly-ordered list. See the preview for results!

Removed apps/website/src/util/fetchLatestVersion.ts as it appeared to be unused.

@Jiralite Jiralite requested a review from a team as a code owner January 10, 2025 05:42
@Jiralite Jiralite requested a review from iCrawl January 10, 2025 05:42
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 6:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 6:39am

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.99%. Comparing base (9a40073) to head (ad965c9).

Files with missing lines Patch % Lines
apps/website/src/middleware.ts 0.00% 3 Missing ⚠️
apps/website/src/util/fetchVersions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10695      +/-   ##
==========================================
+ Coverage   37.96%   37.99%   +0.02%     
==========================================
  Files         239      238       -1     
  Lines       14875    14866       -9     
  Branches     1377     1376       -1     
==========================================
  Hits         5648     5648              
+ Misses       9216     9207       -9     
  Partials       11       11              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite marked this pull request as draft January 10, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants