Include "allow-forms" value in <amp-iframe> "sandbox" attribute #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Disqus Team,
In this small edit I'm proposing the inclusion of the "allow-forms" value in "sandbox" attribute.
This is intended to support form submission in , as well as form submissions in popups spawned by (for instance, if the user needs to register an account w/ Disqus). I'm hoping this fixes an issue I'm seeing, where form-submission does not go through in the context of the account sign-in popup, but it may need more testing on your end to confirm.
Feel free to reach out with any questions!
Best,
Eric