Use crumb to get return type of a templated function or the type of a cast #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuukk
changed the title
|
And now also supports casting!
|
|
Not ready to be merged until DCD can be compiled with latest version of libdparse/dsymbol.. |
WebFreak001
reviewed
Jun 20, 2022
| else if (currentSymbol.type is null) | ||
| break; // this is a fully resolved type (casting)! | ||
| else if (currentSymbol.type.name == "void") | ||
| return; // it's void, no need to continue |
yes, i am working on that right now |
|
The more i test things, the more i realize that the code is broken, DSymbol doesn't hold enough information to make such guesses about templates/casting.. therefore it produces a lot wrong completions as a side effect The code base is also challenging to read and follow, i'm not sure i will be able to continue this PR, it's very challenging |
|
I think i managed to find a way to do it reliably, but that'll need to also touch DCD I will send a PR once DSymbol and DCD get merged together, so the PR will be easier to review |
|
moved to dlang-community/DCD#681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Don't mind the colors, it's just my theme that is broken