Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Deprecate typesafe variadic class arguments #20673

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 9, 2025

Testing it as an error first to see if anything on buildkite relies on this feature.

@dkorpel dkorpel added the Review:WIP Work In Progress - not ready for review or pulling label Jan 9, 2025
@dlang-bot dlang-bot added the WIP label Jan 9, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20673"


if (isTypesafeVariadic && t.isTypeClass())
{
.error(loc, "cannot have typesafe variadic parameter of class type `%s`", t.toChars());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks around class


if (isTypesafeVariadic && t.isTypeClass())
{
.error(loc, "cannot have typesafe variadic parameter of class type `%s`", t.toChars());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, PR title says deprecation, this is an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review:WIP Work In Progress - not ready for review or pulling WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants