Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop SLES 15-SP3 support #383

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

prabhav-thali
Copy link
Contributor

Dropped support for SLES 15-sp3 as it is EOL.
Updated the opensuse_repo URL as for SLES 15-SP5, container-selinux is present in the Opensuse_factory repo. And made it generic for SLES 15-sp4 and SLES 15-sp5.

Signed-off-by: Prabhav Thali [email protected]

@prabhav-thali
Copy link
Contributor Author

Hi @thaJeztah,
Could you please take a look? Thanks.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed your ping 🙈

SGTM

@@ -450,7 +450,7 @@ do_install() {
esac
;;

centos|rhel|sles)
centos|rhel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wondering now if we need this option in the switch at all 🤔 (looks like same code is also in the *) case 🤔

@thaJeztah thaJeztah merged commit 4a46d61 into docker:master Jan 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants