Update pki nss-cert-import #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pki nss-cert-import has been updated to use the token name in the nickname if specified, otherwise it will use the token name specified in the --token option. The NSSDatabase.addCertificate() in Java (which is used by pki nss-cert-import) has been modified to call the new PK11Store.importCert() instead of addPEMCertificate() which depends on certutil -A. The NSSDatabase.add_cert() in Python has been updated to use JSS (via pki nss-cert-import) by default. It has also been updated to provide the input cert via standard input instead of file to avoid permission issues.
|
Kudos, SonarCloud Quality Gate passed! |
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pki nss-cert-importhas been updated to use the token name in the nickname if specified, otherwise it will use the token name specified in the--tokenoption.The
NSSDatabase.addCertificate()in Java (which is used bypki nss-cert-import) has been modified to call the newPK11Store.importCert()instead ofaddPEMCertificate()which depends oncertutil -A.The
NSSDatabase.add_cert()in Python has been updated to use JSS (viapki nss-cert-import) by default. It has also been updated to provide the input cert via standard input instead of file to avoid permission issues.