Fix pylint failure #4607
Merged
Fix pylint failure #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KRAConnector.deregister() is always executed with critical_failure=True, so the param can be dropped and the the code that uses the param can be simplified, and also the outer try-except block can be removed. This will also fix pylint broad-exception-caught failure.
The TPSConnector.deregister() is always executed with critical_failure=True, so the param can be dropped and the the code that uses the param can be simplified, and also the outer try-except block can be removed.
|
Kudos, SonarCloud Quality Gate passed! |
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KRAConnector.deregister()andTPSConnector.deregister()are always executed withcritical_failure=True, so the param can be dropped and the the code that uses the param can be simplified, and also the outertry-exceptblock can be removed.This will also fix
pylintbroad-exception-caughtfailure.