Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki-server <subsystem>-create #4624

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add pki-server <subsystem>-create #4624

merged 1 commit into from
Nov 28, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Nov 28, 2023

The pki-server <subsystem>-create command has been added to create a basic subsystem with the initial files/folders which will allow the admin to run other pki-server <subsystem>-* commands to prepare the subsystem database.

The test for installing CA with existing DS has been modified to use pki-server <subsystem>-* to create the subsystem, set up database connection, VLVs, database user, and admin user.

The initialization.py has been modified such that pkispawn can finish the existing subsystem installation.

The PKISubsystem.create_conf() has been modified to create the initial CS.cfg and registry.cfg.

The subsystem_layout.py has been modified to overwrite the existing CS.cfg, but in the future it should preserve the parameters already set in the existing file.

The PKIServer.load_subsystems() has been modified to create the PKISubsystem object if the subsystem folder exists regardless of its current content.

https://github.com/dogtagpki/pki/wiki/PKI-Server-Subsystem-Database-CLI
https://github.com/dogtagpki/pki/wiki/Setting-up-CA-Database-User
https://github.com/dogtagpki/pki/wiki/Setting-up-CA-Admin-User

@edewata edewata requested a review from fmarco76 November 28, 2023 05:58
The pki-server <subsystem>-create command has been added to
create a basic subsystem with the initial files/folders which
will allow the admin to run other pki-server <subsystem>-*
commands to prepare the subsystem database.

The test for installing CA with existing DS has been modified
to use pki-server <subsystem>-* to create the subsystem, set
up database connection, VLVs, database user, and admin user.

The initialization.py has been modified such that pkispawn
can finish the existing subsystem installation.

The PKISubsystem.create_conf() has been modified to create
the initial CS.cfg and registry.cfg.

The subsystem_layout.py has been modified to overwrite the
existing CS.cfg, but in the future it should preserve the
parameters already set in the existing file.

The PKIServer.load_subsystems() has been modified to create
the PKISubsystem object if the subsystem folder exists
regardless of its current content.
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Nov 28, 2023

@fmarco76 Thanks!

@edewata edewata merged commit 2ac7ae1 into dogtagpki:master Nov 28, 2023
129 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants