https://issues.redhat.com/browse/RHCS-4506 #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
reviewed
Nov 28, 2023
pki.spec
Outdated
| Requires: %{product_id}-base = %{version}-%{release} | ||
| Requires: jss >= 4.9.6, jss < 5.0 | ||
| Requires: ldapjdk >= 4.23 | ||
| Requires: %{product_id}-base >= %{version}-%{release} |
There was a problem hiding this comment.
For this one we probably should use = since it comes from the same package, so we want to use the exact same version and release number:
Requires: %{product_id}-base >= %{version}-%{release}
pki.spec
Outdated
| @@ -459,7 +459,7 @@ Provides: pki-tools = %{version}-%{release} | |||
|
|
|||
| Requires: openldap-clients | |||
| Requires: nss-tools >= 3.36.1 | |||
| Requires: %{product_id}-base-java = %{version}-%{release} | |||
| Requires: %{product_id}-base-java >= %{version}-%{release} | |||
pki.spec
Outdated
Comment on lines
493
to
494
| Requires: %{product_id}-symkey >= %{version}-%{release} | ||
| Requires: %{product_id}-tools >= %{version}-%{release} |
pki.spec
Outdated
| @@ -170,7 +170,7 @@ BuildRequires: zip | |||
| BuildRequires: %{java_devel} | |||
| BuildRequires: javapackages-tools | |||
| BuildRequires: redhat-rpm-config | |||
| BuildRequires: ldapjdk = 4.23 | |||
| BuildRequires: ldapjdk >= 4.23 | |||
There was a problem hiding this comment.
You can put the upper limit too if you want:
ldapjdk >= 4.23, ldapjdk < 5.0
pki.spec
Outdated
| @@ -800,9 +800,9 @@ BuildArch: noarch | |||
| Obsoletes: pki-console < %{version}-%{release} | |||
| Provides: pki-console = %{version}-%{release} | |||
|
|
|||
| BuildRequires: idm-console-framework = 1.3 | |||
| BuildRequires: idm-console-framework >= 1.3 | |||
There was a problem hiding this comment.
Same thing:
idm-console-framework >= 1.3, idm-console-framework < 2.0
ladycfu
force-pushed
the
ticket-RHCS-4506-spec-dependencies
branch
from
fb9298d to
5399676
Compare
This patch attempts to fix the dependency issues in the spec file. fixes https://issues.redhat.com/browse/RHCS-4506
ladycfu
force-pushed
the
ticket-RHCS-4506-spec-dependencies
branch
from
5399676 to
be4f50a
Compare
edewata
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to fix the dependency issues in the spec file.
fixes https://issues.redhat.com/browse/RHCS-4506