Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug2253044-AKI-non-SHA1-support #4632

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

ladycfu
Copy link
Contributor

@ladycfu ladycfu commented Dec 5, 2023

This patch is to address the issue where the AKI would not match the SKI in the case when SHA-1 is not selected for calculationg SKI for root ca. CA profiles have also been changed so that the SKI will come before AKI so that SKI could propagate to AKI properly in the case of a root CA.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=2253044

This patch is to address the issue where the AKI would not match the SKI
in the case when SHA-1 is not selected for calculationg SKI for root ca.
CA profiles have also been changed so that the SKI will come before AKI
so that SKI could propagate to AKI properly in the case of a root CA.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=2253044
@ladycfu ladycfu requested a review from jmagne December 5, 2023 22:56
Copy link
Contributor

@jmagne jmagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would just make sure that you have modified all the profiles we need to modify, and that the order is correct, just to double check.

@ladycfu
Copy link
Contributor Author

ladycfu commented Dec 6, 2023

will deal with upgrade script for the profiles later.

@ladycfu ladycfu merged commit dcfa946 into dogtagpki:v10.13 Dec 6, 2023
48 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants